Re: [patch] checkpatch.pl: revert wrong --file message
From: Andi Kleen
Date: Mon Feb 18 2008 - 05:16:56 EST
> People, who do cleanups - I'm not talking about running lindent here -
> read through the code while they fix it up.
Please feel free to repeat my little experiment: give someone who sends
you a lot of checkpatch.pl only patches a simple task that actually
requires a little actual code change and at least a little localized
understanding of code. See how well they do.
In my case it was the "turn ->ioctl into ->unlocked_ioctl" task,
which was simple enough.
I found that there were a lot of useful unlocked_ioctl patches
in the end, but they all only came from people who hadn't submitted
any checkpatch.pl only patches before.
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/