Re: [PATCH 2.6.24 1/1] sch_htb: fix "too many events" situation

From: David Miller
Date: Mon Feb 18 2008 - 02:28:08 EST


From: Martin Devera <devik@xxxxxx>
Date: Fri, 15 Feb 2008 00:02:56 +0100

> From: Martin Devera <devik@xxxxxx>
>
> HTB is event driven algorithm and part of its work is to apply
> scheduled events at proper times. It tried to defend itself from
> livelock by processing only limited number of events per dequeue.
> Because of faster computers some users already hit this hardcoded
> limit.
> This patch uses loops_per_jiffy variable to limit event processing
> up to single jiffy interval and then delay remainder to other
> jiffy.
>
> Signed-off-by: Martin Devera <devik@xxxxxx>

I think we would be wise to use something other than loops_per_jiffy.

Depending upon the loop calibration method used by a particular
architecture it can me one of many different things.

Some platforms don't even make use of it and thus leave it at it's
default value of "1<<12", so using it as a heuristic here is arbitrary
at best.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/