RE: [PATCH 5/6] Add OF-tree support to RapidIO controller driver.

From: Zhang Wei
Date: Mon Feb 18 2008 - 02:24:56 EST




> -----Original Message-----
> From: Kumar Gala [mailto:galak@xxxxxxxxxxxxxxxxxxx]
>
>
> On Feb 4, 2008, at 11:44 PM, Stephen Rothwell wrote:
>
> >>
> >> + aw = *(u32 *)of_get_property(dev->node, "#address-cells", NULL);
> >> + sw = *(u32 *)of_get_property(dev->node, "#size-cells", NULL);
> >
> > What happens if either of these properties is missing?
>
> Should we add __must_check to of_get_property?
>

You are right, I'll add the checking here.

Thanks!
Wei.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/