Re: 2.6.24-git16 Oops @ sysfs_move_dir w/ btdelconn
From: Dave Young
Date: Sun Feb 17 2008 - 21:37:31 EST
On Mon, Feb 18, 2008 at 09:01:05AM +0800, Dave Young wrote:
> On Feb 18, 2008 8:52 AM, Barnaby <diannibd@xxxxxxxxx> wrote:
> >
> > On Feb 17, 2008 4:59 AM, Dave Young <hidave.darkstar@xxxxxxxxx> wrote:
> > >
> > > On Feb 16, 2008 1:16 PM, Barnaby <diannibd@xxxxxxxxx> wrote:
> > > >
> > > > On Fri, Feb 15, 2008 at 6:15 PM, Dave Young <hidave.darkstar@xxxxxxxxx> wrote:
> > > > >
> > > > > On Fri, Feb 15, 2008 at 8:04 AM, Barnaby <diannibd@xxxxxxxxx> wrote:
> > > > > > Answers at the bottom..
> > > > > >
> > > > > >
> > > > > >
> > > > > > On 2/13/08, Dave Young <hidave.darkstar@xxxxxxxxx> wrote:
> > > > > > > On Feb 8, 2008 12:57 AM, Barnaby <diannibd@xxxxxxxxx> wrote:
> > > > > > > > Hello Dave,
> > > > > > >
> > > > > > > Add someone to cc-list
> > > > > > >
> > > > > > >
> > > > > > > >
> > > > > > > > Got your name and email from the 2.6.24-git16 changelog.
> > > > > > > >
> > > > > > > > I get these Oops when suspending or doing..
> > > > > > > >
> > > > > > > > echo disable > /proc/acpi/ibm/bluetooth
> > > > > > > > or
> > > > > > > > echo 0 > /sys/devices/platform/thinkpad_acpi/bluetooth_enable
> > > > > > > >
> > > > > > > > # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> > > > > > > >
> > > > > > > > Feb 7 09:19:47 BUG: unable to handle kernel NULL pointer dereference
> > > > > > > > at 00000008
> > > > > > > > Feb 7 09:19:47 IP: [<c0183188>] sysfs_move_dir+0x16/0x1ab
> > > > > > > > Feb 7 09:19:47 *pde = 00000000
> > > > > > > > Feb 7 09:19:47 Oops: 0000 [#1] PREEMPT
> > > > > > > > Feb 7 09:19:47 Modules linked in: xt_tcpudp hidp l2cap snd_seq
> > > > > > > > snd_seq_device snd_pcm_oss snd_mixer_oss sr_mod cdrom iptable_filter
> > > > > > > > iptable_nat nf_conntrack_ipv4 iptable_mangle ipt_LOG xt_state ipt_ttl
> > > > > > > > ipt_MASQUERADE nf_nat nf_conntrack xt_DSCP ip_tables x_tables usbhid
> > > > > > > > ipw2200 ieee80211 ieee80211_crypt thinkpad_acpi backlight acpi_cpufreq
> > > > > > > > radeon drm intel_agp agpgart snd_intel8x0 snd_ac97_codec ac97_bus
> > > > > > > > snd_pcm snd_timer snd soundcore snd_page_alloc button
> > > > > > > > thermal processor hci_usb bluetooth
> > > > > > > > Feb 7 09:19:47
> > > > > > > > Feb 7 09:19:47 Pid: 1412, comm: btdelconn Not tainted (2.6.24-git16 #1)
> > > > > > > > Feb 7 09:19:47 EIP: 0060:[<c0183188>] EFLAGS: 00010246 CPU: 0
> > > > > > > > Feb 7 09:19:47 EIP is at sysfs_move_dir+0x16/0x1ab
> > > > > > > > Feb 7 09:19:47 EAX: c039476c EBX: f7dd0480 ECX: f6da9f58 EDX: f7dd0480
> > > > > > > > Feb 7 09:19:47 ESI: 00000000 EDI: f5ea0c40 EBP: fffffff4 ESP: f6da9f30
> > > > > > > > Feb 7 09:19:47 DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068
> > > > > > > > Feb 7 09:19:47 Process btdelconn (pid: 1412, ti=f6da8000
> > > > > > > > task=f6fd1550 task.ti=f6da8000)
> > > > > > > > Feb 7 09:19:47 Stack: f56f4ea4 f7dd0480 f5ea0c40 f56f4ea4 f7dd0480
> > > > > > > > f5ea0c40 fffffff4 c01c71a0
> > > > > > > > Feb 7 09:19:47 f5ea0800 c034a793 f5ea0c40 f5ea0800 f5ea0800 00000000
> > > > > > > > f56f4e3c 00000000
> > > > > > > > Feb 7 09:19:47 00000000 f7dd0480 c0219d48 f56f4ea4 ffffffea f56f4e3c
> > > > > > > > f5fc7c88 f5fc7c00
> > > > > > > > Feb 7 09:19:47 Call Trace:
> > > > > > > > Feb 7 09:19:47 [<c01c71a0>] kobject_move+0x9e/0xeb
> > > > > > > > Feb 7 09:19:47 [<c0219d48>] device_move+0x41/0xdf
> > > > > > > > Feb 7 09:19:47 [<f88657f6>] del_conn+0x0/0x43 [bluetooth]
> > > > > > > > Feb 7 09:19:47 [<f8865807>] del_conn+0x11/0x43 [bluetooth]
> > > > > > > > Feb 7 09:19:47 [<c012339b>] run_workqueue+0x83/0x10e
> > > > > > > > Feb 7 09:19:47 [<c0123996>] worker_thread+0x0/0xb5
> > > > > > > > Feb 7 09:19:47 [<c0123a41>] worker_thread+0xab/0xb5
> > > > > > > > Feb 7 09:19:47 [<c0125d5e>] autoremove_wake_function+0x0/0x2d
> > > > > > > > Feb 7 09:19:47 [<c0125caa>] kthread+0x36/0x5c
> > > > > > > > Feb 7 09:19:47 [<c0125c74>] kthread+0x0/0x5c
> > > > > > > > Feb 7 09:19:47 [<c01047cb>] kernel_thread_helper+0x7/0x10
> > > > > > > > Feb 7 09:19:47 =======================
> > > > > > > > Feb 7 09:19:47 Code: ff b8 6c 47 39 c0 e8 64 f1 15 00 89 f0 83 c4 10
> > > > > > > > 5b 5e 5f 5d c3 55 57 56 53 89 d3 83 ec 0c 8b 70 1c b8 6c 47 39 c0 e8
> > > > > > > > 3a f1 15 00 <8b> 56 08 85 d2 75 04 0f 0b eb fe 8b 5b 1c b8 a0 47 39 c0
> > > > > > > > 85 db
> > > > > > > > Feb 7 09:19:47 EIP: [<c0183188>] sysfs_move_dir+0x16/0x1ab SS:ESP
> > > > > > > > 0068:f6da9f30
> > > > > > > > Feb 7 09:19:47 ---[ end trace e0c3df2b167f1367 ]---
> > > > > > > > Feb 7 09:27:44 usb 4-1: new full speed USB device using uhci_hcd and address 4
> > > > > > > > Feb 7 09:27:44 usb 4-1: configuration #1 chosen from 1 choice
> > > > > > > > Feb 7 09:28:06 BUG: unable to handle kernel NULL pointer dereference
> > > > > > > > at 00000020
> > > > > > > > Feb 7 09:28:06 IP: [<c0182a99>] sysfs_addrm_start+0x1e/0x7a
> > > > > > > > Feb 7 09:28:06 *pde = 00000000
> > > > > > > > Feb 7 09:28:06 Oops: 0000 [#2] PREEMPT
> > > > > > > > Feb 7 09:28:06 Modules linked in: xt_tcpudp hidp l2cap snd_seq
> > > > > > > > snd_seq_device snd_pcm_oss snd_mixer_oss sr_mod cdrom iptable_filter
> > > > > > > > iptable_nat nf_conntrack_ipv4 iptable_mangle ipt_LOG xt_state ipt_ttl
> > > > > > > > ipt_MASQUERADE nf_nat nf_conntrack xt_DSCP ip_tables x_tables usbhid
> > > > > > > > ipw2200 ieee80211 ieee80211_crypt thinkpad_acpi backlight acpi_cpufreq
> > > > > > > > radeon drm intel_agp agpgart snd_intel8x0 snd_ac97_codec ac97_bus
> > > > > > > > snd_pcm snd_timer snd soundcore snd_page_alloc button
> > > > > > > > thermal processor hci_usb bluetooth
> > > > > > > > Feb 7 09:28:06
> > > > > > > > Feb 7 09:28:06 Pid: 11774, comm: hidd Tainted: G D (2.6.24-git16 #1)
> > > > > > > > Feb 7 09:28:06 EIP: 0060:[<c0182a99>] EFLAGS: 00010246 CPU: 0
> > > > > > > > Feb 7 09:28:06 EIP is at sysfs_addrm_start+0x1e/0x7a
> > > > > > > > Feb 7 09:28:06 EAX: c0394760 EBX: 00000000 ECX: 00000000 EDX: 00000000
> > > > > > > > Feb 7 09:28:06 ESI: f3733cb4 EDI: f3733cc4 EBP: 00000000 ESP: f3733ca4
> > > > > > > > Feb 7 09:28:06 DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068
> > > > > > > > Feb 7 09:28:06 Process hidd (pid: 11774, ti=f3732000 task=f3673550
> > > > > > > > task.ti=f3732000)
> > > > > > > > Feb 7 09:28:06 Stack: f6c14680 f7f9d6ec fffffff4 c0182e80 00000000
> > > > > > > > 00000000 00000000 00000000
> > > > > > > > Feb 7 09:28:06 f6c14680 f6c14680 fffffffe f56d563c c0182ee1 f3733cdc
> > > > > > > > c01c6daa f5fa4c48
> > > > > > > > Feb 7 09:28:06 c01c6eb9 f6e660f0 00000000 f6c14680 f6e660f0 f56d563c
> > > > > > > > c01c6fe9 f3733d30
> > > > > > > > Feb 7 09:28:06 Call Trace:
> > > > > > > > Feb 7 09:28:06 [<c0182e80>] create_dir+0x33/0x6b
> > > > > > > > Feb 7 09:28:06 [<c0182ee1>] sysfs_create_dir+0x29/0x3b
> > > > > > > > Feb 7 09:28:06 [<c01c6daa>] kobject_get+0xf/0x13
> > > > > > > > Feb 7 09:28:06 [<c01c6eb9>] kobject_add_internal+0xab/0x144
> > > > > > > > Feb 7 09:28:06 [<c01c6fe9>] kobject_add_varg+0x39/0x42
> > > > > > > > Feb 7 09:28:06 [<c01c723c>] kobject_add+0x4a/0x4e
> > > > > > > > Feb 7 09:28:06 [<c0219c62>] get_device_parent+0xd7/0xfb
> > > > > > > > Feb 7 09:28:06 [<c021a2e1>] device_add+0x79/0x418
> > > > > > > > Feb 7 09:28:06 [<c01ca789>] snprintf+0x1c/0x1f
> > > > > > > > Feb 7 09:28:06 [<c026c0e3>] input_register_device+0xb2/0x188
> > > > > > > > Feb 7 09:28:06 [<c027b9a7>] hidinput_connect+0x24ff/0x2530
> > > > > > > > Feb 7 09:28:06 [<f895d726>] hidp_send_report+0x143/0x14f [hidp]
> > > > > > > > Feb 7 09:28:06 [<f895e486>] hidp_sock_ioctl+0xe2/0x1fa [hidp]
> > > > > > > > Feb 7 09:28:06 [<c0128259>] enqueue_hrtimer+0xd7/0xe2
> > > > > > > > Feb 7 09:28:06 [<c011375e>] hrtick_set+0x6a/0xc3
> > > > > > > > Feb 7 09:28:06 [<c0103948>] do_notify_resume+0x5e3/0x644
> > > > > > > > Feb 7 09:28:06 [<c027f217>] sock_ioctl+0x1ab/0x1cd
> > > > > > > > Feb 7 09:28:06 [<c027f06c>] sock_ioctl+0x0/0x1cd
> > > > > > > > Feb 7 09:28:06 [<c015aaa4>] do_ioctl+0x1c/0x5d
> > > > > > > > Feb 7 09:28:06 [<c015ad11>] vfs_ioctl+0x22c/0x23f
> > > > > > > > Feb 7 09:28:06 [<c02808b3>] sys_socketcall+0xd2/0x181
> > > > > > > > Feb 7 09:28:06 [<c015ad50>] sys_ioctl+0x2c/0x44
> > > > > > > > Feb 7 09:28:06 [<c0103c3a>] sysenter_past_esp+0x5f/0x85
> > > > > > > > Feb 7 09:28:06 [<c02e0000>] piix_init_one+0x1a7/0x525
> > > > > > > > Feb 7 09:28:06 =======================
> > > > > > > > Feb 7 09:28:06 Code: 89 f8 e8 3d ff ff ff 31 c0 5b 5e 5f c3 57 b9 04
> > > > > > > > 00 00 00 56 89 c6 53 31 c0 89 d3 89 f7 f3 ab b8 60 47 39 c0 89 16 e8
> > > > > > > > 29 f8 15 00 <8b> 53 20 b9 e3 27 18 c0 a1 fc 19 40 c0 53 e8 0c e0 fd ff
> > > > > > > > 5b 85
> > > > > > > > Feb 7 09:28:06 EIP: [<c0182a99>] sysfs_addrm_start+0x1e/0x7a SS:ESP
> > > > > > > > 0068:f3733ca4
> > > > > > > > Feb 7 09:28:06 ---[ end trace e0c3df2b167f1367 ]---
> > > > > > > >
> > > > > > > > # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> > > > > > > >
> > > > > > > > This does not happen in 2.6.22
> > > > > > > >
> > > > > > > > Please let me know if you need more info, or need me to report this elsewhere.
> > > > > > >
> > > > > > >
> > > > > > > Does 2.6.24 work?
> > > > > >
> > > > > > Just had an oops w/ 2.6.24.2 and was about to send the attached to
> > > > > > lkml. Although it happens less frequently in 2.6.24.2 and I don't see
> > > > > > btdelconn in the single Oops I've had in 2.6.24.2
> > > > > >
> > > > > >
> > > > > > > How do you use bluetooth, just as hid devices?
> > > > > >
> > > > > > Just one bluetooth mouse.
> > > > > >
> > > > > >
> > > > > > > Could you post full dmesg?
> > > > > >
> > > > > > I'll attach the plain text file will most of the output requested by
> > > > > >
> > > > > > /usr/src/linux/REPORTING-BUGS
> > > > > >
> > > > > > the outpu of DMESG from after booting to recover from the Oops is at the bottom.
> > > > > >
> > > > > > > Regards
> > > > > > >
> > > > > > > dave
> > > > > >
> > > > > > Thank you!
> > > > > >
> > > > > > Barnaby
> > > > > >
> > > > >
> > > > > Hi,
> > > > >
> > > > > Please try the attached patch and help to verify.
> > > > >
> > > > > Regards
> > > > > dave
> > > > >
> > > >
> > > > Hi,
> > > >
> > > > Oops is still present, heres what I did..
> > >
> > > For your case could you please try another patch? Thanks.
> > > (Attached because I can not access my own linux pc.)
> > >
> > > Regards
> > > dave
> > >
> >
> > Oops is no longer seen,
>
> Thanks for your test.
>
> Unfortunatly, hidd device is the child of hci conn device as well, so
> it should not be moved to NULL.
>
> This is my lost, I will send this patch again later.
>
> But there's still a hidden weird bug when we move the device while
> suspend/resume, I will continue to debug the issue.
Hi, Barnaby
Could you help to test with the follownig patch to print some debug
info? (Please firstly revert the previous one before apply)
Thanks.
---
diff -upr linux/fs/sysfs/dir.c linux.new/fs/sysfs/dir.c
--- linux/fs/sysfs/dir.c 2008-02-18 09:43:06.000000000 +0800
+++ linux.new/fs/sysfs/dir.c 2008-02-18 09:48:57.000000000 +0800
@@ -839,6 +839,14 @@ int sysfs_move_dir(struct kobject *kobj,
struct dentry *old_dentry = NULL, *new_dentry = NULL;
int error;
+ printk("###################### \n");
+ printk("kobj = %p\n", kobj);
+ printk("kobj->sd = %p\n", kobj->sd);
+ printk("kobj->sd->s_parent = %p\n", kobj->sd->s_parent);
+ printk("new_parent_kobj = %p\n", new_parent_kobj);
+ printk("new_parent_kobj->sd = %p\n", new_parent_kobj->sd);
+ printk("###################### \n");
+
mutex_lock(&sysfs_rename_mutex);
BUG_ON(!sd->s_parent);
new_parent_sd = new_parent_kobj->sd ? new_parent_kobj->sd : &sysfs_root;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/