Re: 2.6.25-rc2 vdso_install breaks user "make install"

From: Sam Ravnborg
Date: Sun Feb 17 2008 - 14:35:21 EST


On Sat, Feb 16, 2008 at 12:36:10PM +0100, Sam Ravnborg wrote:
> On Fri, Feb 15, 2008 at 07:42:11PM -0800, Roland McGrath wrote:
> > Perhaps it makes more sense to have vdso_install be a dependency of
> > modules_install rather than install, since they both put things in /lib/modules.
> > The installed vdso images are potentially useful for a kernel when you
> > aren't bothering to build or install any modules, but those images are only
> > ever useful for sophisticated debugging uses anyway.
> >
> > Sam, any thoughts? (See arch/x86/Makefile and arch/powerpc/Makefile.)
>
> Installing the vdso files as aprt of modules_install would be
> unintuitive as this has nothing to do with modules.
>
> And since you wrote:
> > useful for sophisticated debugging uses anyway
> I suggest to make the vdso_install step independent as
> in following patch.
> [Note: help docs needs to mention the new target].
>
> This solves the issue at ahnd and still gives us the posibility
> to install the files should they be needed.

Roland - if you agree will you please submit the patch
to the x86 people.
You can tag it:
Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
or Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

as you like.

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/