Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace!likely(x) by likely(!x)

From: Rene Herman
Date: Sat Feb 16 2008 - 21:31:51 EST


On 16-02-08 20:01, H. Peter Anvin wrote:
Roel Kluin wrote:
Not entirely sure who to send this to
---
Replace !likely(x) by likely(!x)

Whoa...

Are you sure this is correct?

!likely(x) is equivalent to unlikely(!x)

Not with respect to its value I believe? likely(x) == !!(x), and unlikely(!x) == !!(!x) = !x, so conditions work out differently?

not the opposite, so this is a functional change...

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/