Re: [PATCHSET] printk: implement printk_header() and merging printk,take #3

From: Mark Lord
Date: Sat Feb 16 2008 - 09:14:07 EST


Tejun Heo wrote:
Andrew Morton wrote:
So, I guess it's NACK w/o suggested alternatives, right?
I wouldn't nack without good reasons, and I have none here. I don't have
very strong opinions either way.

I was just wondering whether I should just go with snprintf dancing in
eh_link_report, which does make sense if not many need merging printk.
..

Any chance you could poke through snprintf() and look for the off-by-one bug
on the return result? (I think it happens when "n" is exceeded).

:)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/