Re: + bluetooth-fix-warning-in-net-bluetooth-hci_sysfsc.patchadded to -mm tree

From: David Miller
Date: Sat Feb 16 2008 - 04:27:24 EST


From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Fri, 15 Feb 2008 20:49:33 -0800

> Subject: bluetooth: fix warning in net/bluetooth/hci_sysfs.c
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>
> net/bluetooth/hci_sysfs.c: In function 'del_conn':
> net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment used as truth value
>
> Cc: Dave Young <hidave.darkstar@xxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Linus barfed when this exact patch got posted a few weeks
ago, he said he considers just adding parenthesis to quiet
this warning awful and explicit NULL test should be used.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/