Re: [PATCH 02/14] [ISDN] Hisax: eliminate many unnecessary references to CardType[]

From: Sam Ravnborg
Date: Fri Feb 15 2008 - 08:39:24 EST


On Wed, Oct 31, 2007 at 03:42:07AM -0400, Jeff Garzik wrote:
> For the vast majority of CardType[card->typ] uses (but not all!),
> the string is constant for each driver. Therefore, we may replace
> CardType[card->typ] with the actual string describing the driver, making
> each printk() a bit more simple.
>
> This also has the nice, intended side effect of greatly reducing
> external references to hisax global CardType[]. This will be of value
> once the ISDN drivers are converted to the ISA/PCI/PNP hotplug APIs.
>
> Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx>

Looks good. No comments.

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/