Re: [PATCH 05/11] ata: replace macro with static inline in libata.h

From: Harvey Harrison
Date: Thu Feb 14 2008 - 12:59:44 EST


On Thu, 2008-02-14 at 12:01 +0000, Alan Cox wrote:
> On Wed, 13 Feb 2008 21:14:18 -0800
> Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:
>
> > Avoid a metric ton of sparse warnings like:
> > drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one
> > drivers/ata/pata_ali.c:176:14: originally declared here
>
> NAK that appears to be a sparse bug.
>
> 1-4/6-10 Acked-by: Alan Cox <alan@xxxxxxxxxx>
>

No worries, for something like this it had better be obviously correct
or not applied. I will try to come up with something more palatable.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/