Re: [PATCH] Add MS_BIND_FLAGS mount flag

From: Miklos Szeredi
Date: Thu Feb 14 2008 - 12:40:31 EST


> > And I'm not against doing it with the "at*" variants, as Trond
> > suggested.
>
> If you're going to change the syscall, then you should ensure that it
> solves _all_ the problems that are known at this time. Ignoring the
> automounter issue is just going to force us to redo the syscall in a
> couple of months...

Sure.

Although, an (almost) equivalent userspace code would be:

mount_fooat(int fd, const char *path)
{
char tmpbuf[64];
int tmpfd = openat(fd, path);

sprintf(tmpbuf, "/proc/self/fd/%i", tmpfd);
return mount_foo(tmpbuf, ...);
}

Or is there something (other than not requiring proc) that the *at
variant gives?

Miklos

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/