Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB fixes

[Ricardo Cerqueira]

On Wed, 2008-02-13 at 10:45 -0800, Trent Piepho wrote:
> On Wed, 13 Feb 2008, Mauro Carvalho Chehab wrote:
> > On Tue, 12 Feb 2008 21:21:43 -0800 (PST)
> > Trent Piepho <xyzzy@xxxxxxxxxxxxx> wrote:
> >
> > The version with problems is the one dated by Jan, 16:
> > http://linuxtv.org/pipermail/v4l-dvb-maintainer/2008-January/006119.html
> >
> > As Ricardo stated on Feb, 5, he fixed the lock issues, that were present on
> > your first revision:
> >
> > http://linuxtv.org/pipermail/v4l-dvb-maintainer/2008-February/006292.html
> 
> I don't see what you are saying in that message.  Ricardo agreed it had a
> race condition and said he would, at some future point, redo it, but I
> never saw a new patch.

You missed it, then:

http://linuxtv.org/pipermail/v4l-dvb-maintainer/2008-February/006293.html

was sent in 25 minutes after the message Mauro mentioned.


> Nobody points to any issues, ever, when this happens.  Look at how broken
> the v4l2 only bttv driver was.  You still can't unload and load cx88-dvb
> since Markus's patch for hotplug, no one's fixed that regression.  Now
> there's yet another race in the cx88 subdriver code.  Maybe the original
> author who added that code should feel some motiviation to fix the
> regressions it caused....

Read the code that was actually committed: here's a helpful link:

http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;h=41a93616082af630e7242cba766a161d7847560b


> 
> I don't have the time or the desire to be the janitor who cleans up after
> sloppy coders' bugs.

You properly raised a red flag, and got a fix in return.
Don't expect fixes to be accompanied by a "are you happy now?"
follow-up; if you took the time to check the first commit, take the time
to read the rest.

Now... it looks as if you simply missed the second patch; it happens.
But next time you feel like sending this kind of message(s) to 3
separate lists, at least check your mail history (or read the code
you're commenting).

--
RC

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/