Re: latest list of unused Kconfig variables

From: Sam Ravnborg
Date: Wed Feb 13 2008 - 10:16:33 EST


On Wed, Feb 13, 2008 at 10:07:27AM -0500, Robert P. J. Day wrote:
> On Wed, 13 Feb 2008, Josh Boyer wrote:
>
> > On Wed, 13 Feb 2008 03:56:34 -0500 (EST)
> > "Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx> wrote:
>
> > > now that 2.6.25-rc1 is out, i can start updating the output from
> > > my scanning scripts. the first updated output is the list of
> > > currently unused Kconfig variables -- variables that are defined
> > > in some Kconfig file somewhere but appear to be entirely unused
> > > throughout the source tree.
> > >
> > > latest output here, sorted by architecture:
> > >
> > > http://www.crashcourse.ca/wiki/index.php/Unused_CONFIG_variables
> > >
> > > as always, there will probably be some false positives for one
> > > reason or another.
> > >
> > > output from the other scanning scripts will be up in short order.
> >
> > You have lots of false positives (or something) for arch/powerpc.
> > Seems your script picked up #define names and comments that happen
> > to match a Kconfig variable?
>
> it always will, given the proclivity of some folks to define their own
> variables with a "CONFIG_" prefix. as i point out on the wiki page, i
> make no attempt to cull that list, i just print it as is, and readers
> will have to peruse the list carefully to see what's meaningful and
> what isn't.

CONFIG_* should in the kernel be assumed a reserved namespace for kconifg.
So any use of variables/defines named CONFIG_* which is not a kconfig
symbol is a bug.

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/