Re: [-mm PATCH] register_memory/unregister_memory clean ups

From: Dave Hansen
Date: Tue Feb 12 2008 - 16:57:31 EST



On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote:
>
> +static void __remove_section(struct zone *zone, unsigned long
> section_nr)
> +{
> + if (!valid_section_nr(section_nr))
> + return;
> +
> + unregister_memory_section(__nr_to_section(section_nr));
> + sparse_remove_one_section(zone, section_nr);
> +}

I do think passing in a mem_section* here is highly superior. It makes
it impossible to pass a pfn in and not get a warning.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/