Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

From: Konrad Rzeszutek
Date: Mon Feb 11 2008 - 18:38:18 EST


> > + if (hdr->id == id_nic) {
> > + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >>
> > 8, + (nic->pci_bdf & 0xff));
> pci_get_bus_and_slot fails in the presence of PCI domains, which are
> getting to be fairly common even in medium sized servers ... what
> happens in that case?

The specification did not take that in to account. The Bus/Dev/Func
information is only present there - no domain information.

Do you think I should implement a search functionality for this so that is
searches through the domains for the bus/dev/func and picks the
first found match (which might be the wrong match)? Or wait to get the spec
updated so that the iBFT will have this data?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/