Re: [3/6] kgdb: core

From: Ingo Molnar
Date: Sun Feb 10 2008 - 11:46:44 EST



* Marcin Slusarz <marcin.slusarz@xxxxxxxxx> wrote:

> if (hex_val < 0)
> break;
> *long_val = (*long_val << 4) | hex_val;
> num++;
> (*ptr)++;

agreed, fixed.

> > + remcom_out_buffer[0] = 'S';
> > + remcom_out_buffer[1] = hexchars[ks->signo >> 4];
> > + remcom_out_buffer[2] = hexchars[ks->signo % 16];
> use pack_hex_byte or & 0xf

fixed.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/