Re: [PATCH] input: driver for USB VoIP phones with CM109 chipset
From: Alfred E. Heggestad
Date: Fri Feb 08 2008 - 16:24:19 EST
Dmitry Torokhov wrote:
Hi Alfred,
On Thu, Feb 07, 2008 at 07:38:10PM +0100, Alfred E. Heggestad wrote:
From: Alfred E. Heggestad <aeh@xxxxxx>
This driver adds support for USB VoIP phones using the CM109 chipset,
such as Komunikate KIP-1000 and Genius G-talk. Keypad is scanned and
events are reported to the input subsystem. The buzzer can be activated
by sending SND_TONE or SND_BELL to the input device. The phone keymap
can be selected in run-time by using the "phone" module parameter.
The driver has been tested with linux 2.6.24 on i386, and also tested
to build cleanly on AMD64.
More testing and code review is welcome..
For a long time I was sitting on the patch not sure what to do about
the pound key, but I think we need to allocate separate keycodes for
remote controls and phones that work regardless of users keymap.
ok, let us define a new KEY_KPPOUND in linux/input.h
this also means that any application wanting to use this key must
be updated to read this new keycode.
do you want me to add a new value for KEY_KPPOUND in linux/input.h
and include it in the next patch, or can you add that value to the
tree first?
Another item is keymap for different devices - the best way to handle
it I think it to implement getkeycodes and setkeycodes methods for
the input device and have alternative keymaps loaded from userspace
instead of adding module parameters.
I agree - I dont want to upgrade the driver code whenever there is a
new phone with different key-mapping.
regarding get/set-keycodes, please let me know how I should
proceed on this one..
The rest of the driver looks great and I am sorry I was ignoring it
for so long.
no worries, I am happy to fix the remaining issues and submit new
versions of the patch..
/alfred
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/