[PATCH] x25_asy: Fix ref count rule violation

From: Alan Cox
Date: Fri Feb 08 2008 - 10:36:20 EST


x25_asy does not take an ldisc reference before calling the flush method.
Fix it to use the helper function we provide.

Signed-off-by: Alan Cox <alan@xxxxxxxxxx>

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-mm1/drivers/net/wan/x25_asy.c linux-2.6.24-mm1/drivers/net/wan/x25_asy.c
--- linux.vanilla-2.6.24-mm1/drivers/net/wan/x25_asy.c 2008-02-06 14:13:27.000000000 +0000
+++ linux-2.6.24-mm1/drivers/net/wan/x25_asy.c 2008-02-06 14:34:55.000000000 +0000
@@ -554,6 +554,7 @@
static int x25_asy_open_tty(struct tty_struct *tty)
{
struct x25_asy *sl = (struct x25_asy *) tty->disc_data;
+ struct tty_ldisc *ld;
int err;

/* First make sure we're not already connected. */
@@ -572,9 +573,7 @@
if (tty->driver->flush_buffer) {
tty->driver->flush_buffer(tty);
}
- if (tty->ldisc.flush_buffer) {
- tty->ldisc.flush_buffer(tty);
- }
+ tty_ldisc_flush(tty);

/* Restore default settings */
sl->dev->type = ARPHRD_X25;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/