Re: [PATCH] CRIS v10: vmlinux.lds.S Fix kernel oops on boot anduse common defines

From: Adrian Bunk
Date: Tue Jan 15 2008 - 16:03:27 EST


On Tue, Jan 15, 2008 at 12:35:15PM -0800, Andrew Morton wrote:
> On Tue, 15 Jan 2008 14:36:24 +0100 Jesper Nilsson <jesper.nilsson@xxxxxxxx> wrote:
>
> > - Move alignment to page size of init data outside ifdef for BLK_DEV_INITRD.
> > The reservation up to page size of memory after init data was previously
> > not done if BLK_DEV_INITRD was undefined.
> > This caused a kernel oops when init memory pages were freed after startup,
> > data placed in the same page as the last init memory would also be freed
> > and reused, with disastrous results.
>
> So this is a 2.6.24 thing?

The cris architecture does not compile in Linus' tree since 2 or 3 years,
so there shouldn't be any hurry for any cris specific patches.

> > - Use macros for initcalls and .text sections.
> >
> > - Replace hardcoded page size constant with PAGE_SIZE define.
> >
> > - Change include/asm-cris/page.h to use the _AC macro to instead
> > of testing __ASSEMBLY__.
>
> Even though those are not.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/