Re: [PATCH 08/10] x86: Change NR_CPUS arrays in numa_64 V2

[Andi Kleen]

travis@xxxxxxx writes:
> +
>  /* Returns the number of the node containing CPU 'cpu' */
>  static inline int cpu_to_node(int cpu)
>  {
> -	return cpu_to_node_map[cpu];
> +	u16 *cpu_to_node_map = x86_cpu_to_node_map_early_ptr;
> +
> +	if (cpu_to_node_map)
> +		return cpu_to_node_map[cpu];
> +	else if(per_cpu_offset(cpu))
> +		return per_cpu(x86_cpu_to_node_map, cpu);
> +	else
> +		return NUMA_NO_NODE;

Seems a little big now to be still inlined.

Also I wonder if there are really that many early callers that it
isn't feasible to just convert them to a early_cpu_to_node(). Also
early_cpu_to_node() should really not be speed critical, so just
linearly searching some other table instead of setting up an explicit
array should be fine for that.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/