[PATCH 2/2] checkstack: fix perl warnings

From: Stephen Hemminger
Date: Mon Jan 14 2008 - 14:22:53 EST


If you enable perl warnings on this script, it shows a couple of problems:

Parentheses missing around "my" list at scripts/checkstack.pl line 105.
Useless use of a variable in void context at scripts/checkstack.pl line 105.
Use of uninitialized value in string eq at scripts/checkstack.pl line 33.

Signed-off-by: Stephen Hemminger <stephen.hemminger@xxxxxxxxxx>

--- a/scripts/checkstack.pl 2008-01-14 11:10:57.000000000 -0800
+++ b/scripts/checkstack.pl 2008-01-14 11:11:56.000000000 -0800
@@ -30,7 +30,7 @@
my (@stack, $re, $x, $xs);
{
my $arch = shift;
- if ($arch eq "") {
+ if (! defined $arch) {
$arch = `uname -m`;
chomp $arch;
}
@@ -102,7 +102,8 @@ sub bysize($) {
#
my $funcre = qr/^$x* <(.*)>:$/;
my $func;
-my $file, $lastslash;
+my $file;
+my $lastslash;

while (my $line = <STDIN>) {
if ($line =~ m/$funcre/) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/