Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driveropt-in

From: Linus Torvalds
Date: Fri Jan 11 2008 - 15:27:53 EST




On Fri, 11 Jan 2008, Matthew Wilcox wrote:
>
> Ivan's patch doesn't start enabling MMCONFIG in more places than we
> currently do. It makes us use conf1 accesses for all accesses below
> 256 bytes. That fixes all known problems to date.

.. and I agree with that patch. But there will be people who try to access
extended space by mistake, and they'll have a hard-locked machine or
something.

> > Tell me what *other* armor plating you could have that actually works?
>
> The armour plating that already exists -- pci=nommconf.

No. It needs to be automatic, OR THE OTHER WAY AROUND.

Ie we disable the unsafe feature on purpose, and then force people who
access it to do so *consciously*.

Extended config space is different, for chissake! It's not even like it's
just a bigger normal config space where normal config accesses just
overflow into it. It really does have different rules etc.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/