Re: [PATCH] Kprobes: Add kprobes smoke tests that run on boot

From: Jim Keniston
Date: Wed Jan 09 2008 - 17:39:42 EST


On Wed, 2008-01-09 at 22:21 +0100, Andi Kleen wrote:
> On Wed, Jan 09, 2008 at 12:24:00PM -0800, Jim Keniston wrote:
> > On Wed, 2008-01-09 at 00:28 +0100, Andi Kleen wrote:
> > > > I have no problem with that, but if we want to make it buildable as a
> > > > module, the call to get_kprobe() needs to be replaced with some other
> > > > gcc-inline-defeating mechanism, or we need to export get_probe(). I
> > >
> > > It's still unclear where noinline does not work (do you have details on that?
> > > It sounds a little dubious) ...
> >
> > Here's a simplified version of a module we've used to gauge kprobes
> > performance. On my system (i386, 2.6.23-rc8 at the moment, gcc version
> > 4.1.2), the module calls the (empty) probed function (probeme) niter
> > times, but reports zero probe hits -- indicating probeme was inlined
> > even though it was declared noinline.
>
> Yes indeed looks like a gcc bug. Have you reported it?
>
> -Andi

There's already a gcc bug report that appears to describe the same
problem:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34563
There seems to be some doubt as to whether it's really a bug, so I added
my 2 cents, including a pointer to this thread.

Jim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/