Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl

From: Matthew Wilcox
Date: Wed Jan 09 2008 - 07:33:22 EST


On Thu, Jan 10, 2008 at 12:53:04PM +0530, Nikanth Karthikesan wrote:
> default:
> printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd);
> + unlock_kernel();
> return -EINVAL;

Surely a bug ... shouldn't this return -ENOTTY?

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/