Re: [PATCH] Change x86 Machine check handler to use unlocked_ioclinstead of ioctl

From: Ingo Molnar
Date: Wed Jan 09 2008 - 05:20:45 EST



* Nikanth Karthikesan <knikanth@xxxxxxx> wrote:

> The Machine check handler registers ioctl handler that is called with
> the BKL held. Changing to register unlocked_ioctl instead. Also mce
> ioctl handler does not seem to need any lock protection.
>
> Change the Machine check handler to use unlocked_ioctl instead of
> ioctl handler. Also the mce ioctl handler does not need any lock
> protection.

thanks, applied to x86.git. Mcelog functionality uses cmpxchg so no need
for the BKL there. The ioctl still being BKL is purely historic and it
was never relied on.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/