Re: [patch] Make MMCONFIG space (extended PCI config space) adriver opt-in issue

From: Ivan Kokshaysky
Date: Sun Dec 23 2007 - 17:32:07 EST


On Sun, Dec 23, 2007 at 10:15:10PM +0100, Martin Mares wrote:
> > - During that probe, you set a flag if any device has capabilities that
> > extend beyond 0xff.
>
> Can this work? The extended capabilities are not linked to the normal
> ones in any way.

Good point.

OTOH, we *do* have a flag for the extended capabilities - dev->cfg_size.
Obviously, the pci probe *without* mmconfig will set it to 256 for *all*
devices.
So Linus' idea of enabling mmconfig per-device makes a lot of sense in the
end - if mmconfig works, it just sets dev->cfg_size to 4096.
Without bloating the struct pci_dev or screwing up innocent arches...

Ivan.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/