Re: [PATCH 2/3] msg.h: Convert m_ts from int to size_t.

From: Andrew Morton
Date: Sat Dec 22 2007 - 05:31:53 EST


On Mon, 17 Dec 2007 03:36:00 +0100 (MET) Richard Knutsson <ricknu-0@xxxxxxxxxxxxxx> wrote:

> Convert m_ts ("message text size") from int to size_t.
>
> Signed-off-by: Richard Knutsson <ricknu-0@xxxxxxxxxxxxxx>
> ---
> Remove some trailing spaces, since we are in the neighborhood.
>
>
> diff --git a/include/linux/msg.h b/include/linux/msg.h
> index 10a3d5a..7a61952 100644
> --- a/include/linux/msg.h
> +++ b/include/linux/msg.h
> @@ -67,8 +67,8 @@ struct msginfo {
> /* one msg_msg structure for each message */
> struct msg_msg {
> struct list_head m_list;
> - long m_type;
> - int m_ts; /* message text size */
> + long m_type;
> + size_t m_ts; /* message text size */
> struct msg_msgseg* next;
> void *security;
> /* the actual message follows immediately */

hm, spose so. But if we're to do this then we'd need to fix qsize and
r_maxsize and various other things. And we'd need to convert msg_bytes to
atomic_size_t, which would prove interesting ;)

So this is at best a partial conversion and the code in there does need
careful checking for the use of appropriate types. Does this patch get us
partway toward the proper solution? Dunno - someone would need to sit down
and work out what the best types are for all those related things.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/