Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

From: Andrew Morton
Date: Wed Dec 19 2007 - 19:46:16 EST


On Wed, 19 Dec 2007 16:41:25 -0800
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> It would be better to just add a stub implementation of
> ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp
> tricks.


And by this I really do mean going into each include/asm-*/pci.h and adding


struct pci_dev; (if needed)
...

static inline void ht_enable_msi_mapping(struct pci_dev *dev)
{
}


no macros, no ifdef tricks, no include tricks. Just straight, clean, fully
typechecked C.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/