Re: No dma_sync_* during pci_probe? (Sparc, post 2.6.22 regression)

From: Benjamin Herrenschmidt
Date: Wed Dec 19 2007 - 16:08:22 EST



On Mon, 2007-12-17 at 16:50 -0800, David Miller wrote:

> The problem is likely what device struct you are passing to
> dma_sync_single_for_device(), it has to be a real pci_dev or similar
> that has it's dev_archdata properly initialized.
>
> I bet dev_archdata in whatever "struct device" is being passed in has
> a NULL iommu pointer or something like that.
>
> Oh yeah, I see what you're doing, that won't work, please pass in
> the correct device struct pointer. Please pass in the &pci_dev->dev
> not this ohci->card.device thing.

Yup, this would crash on powerpc 64 bits as well for the same reason.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/