Re: [PATCH 4/9] tmpfs: allow filepage alongside swappage

From: Erez Zadok
Date: Tue Dec 18 2007 - 17:52:24 EST


In message <Pine.LNX.4.64.0712182200230.27165@xxxxxxxxxxxxxxxxxxxxxx>, Hugh Dickins writes:

> redirty:
> set_page_dirty(page);
> - return AOP_WRITEPAGE_ACTIVATE; /* Return with the page locked */
> + if (wbc->for_reclaim)
> + return AOP_WRITEPAGE_ACTIVATE; /* Return with page locked */
> + unlock_page(page);
> + return 0;

Just curious, but didn't you (or someone else) mention that they wanted to
do away with AOP_WRITEPAGE_ACTIVATE entirely? If these patches are for
2.6.25, would that be the right time?

Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/