Re: [PATCH 2.6.24-rc5-mm 3/3] gpiolib: obsolete drivers/i2c/chips/pca9539.c

From: David Brownell
Date: Mon Dec 17 2007 - 13:10:07 EST


> Date: Mon, 17 Dec 2007 14:33:27 +0800
> From: "eric miao" <eric.y.miao@xxxxxxxxx>
>
> for the following reasons:
>
> 1. there is currently no known users of this driver
>
> 2. the functionality of this driver is well supported with the recent
> proposed drivers/gpio/pca9539.c, using GPIO_LIB
>
> Signed-off-by: eric miao <eric.miao@xxxxxxxxxxx>
> Acked-by: Ben Gardner <bgardner@xxxxxxxxxx>
> ---
> Documentation/i2c/chips/pca9539 | 47 --------
> drivers/i2c/chips/Kconfig | 10 --
> drivers/i2c/chips/Makefile | 1 -
> drivers/i2c/chips/pca9539.c | 196 ----------------------------------

Jean, do you sign off on this? In any case I think this should
be going through your I2C patches.

I'd be a trifle uneasy just deleting this, because it's possible
there are *unknown* users ... and also because nobody's yet done
a userspace interface to the gpiolib infrastructure. (It seems
to be the usual case of nobody wanting such a thing quite enough
to write the code.)

I'd be more comfortable marking it as obsolete and flagging it
for removal a release or two after Eric's new version merges ...
though maybe that's just paranoia.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/