Re: [PATCH] drivers/dma/ioat_dma.c: inlining failed

From: Andrew Morton
Date: Fri Dec 14 2007 - 18:16:45 EST


On Fri, 14 Dec 2007 11:53:28 -0800
"Nelson, Shannon" <shannon.nelson@xxxxxxxxx> wrote:

> >-----Original Message-----
> >From: S.__a__lar Onur [mailto:caglar@xxxxxxxxxxxxx]
> >Sent: Friday, December 14, 2007 11:45 AM
> >To: linux-kernel@xxxxxxxxxxxxxxx
> >Cc: Nelson, Shannon
> >Subject: [PATCH] drivers/dma/ioat_dma.c: inlining failed
> >
> >Hi;
> >
> >After commit 7bb67c14fd3778504fb77da30ce11582336dfced, Linus's
> >git tree gaves following compiliation error with gcc-3.4.6.
> >Following patch solves this issue for me;
> >
> >
> >[...]
> > CC [M] drivers/dma/ioat.o
> > CC [M] drivers/dma/ioat_dma.o
> >drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
> >drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining
> >failed in call to '__ioat1_dma_memcpy_issue_pending': function
> >body not available
> >drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here
> >make[2]: *** [drivers/dma/ioat_dma.o] Hata 1
> >make[1]: *** [drivers/dma] Hata 2
> >make: *** [drivers] Hata 2
> >
> >Signed-off-by: S.__a__lar Onur <caglar@xxxxxxxxxxxxx>
> [...]
>
> Yep. I posted a similar patch with a couple more tweaks after a month ago after Andrew's comments, which hasn't yet moved from -mm to Linus' tree. See http://lkml.org/lkml/2007/11/16/336
>

Nobody told me that it fixed anything serious so I had it scheduled for
2.6.25. I'll move it up.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/