Re: 2.6.22.14 oops msg with commvault galaxy ?

From: Dhaval Giani
Date: Thu Dec 13 2007 - 21:15:09 EST


On Thu, Dec 13, 2007 at 09:21:26PM +0100, Ingo Molnar wrote:
>
> * Kay Sievers <kay.sievers@xxxxxxxx> wrote:
>
> > > > > This one also fails to apply properly at the exact same place
> > > > > has Ingo's previously posted patch. Would need to backport his
> > > > > one.
> > > >
> > > > It depends on a completely reworked sysfs logic, I don't think it
> > > > makes any sense to backport that.
> > >
> > > well, if it fixes a live bug in a still supported stable kernel
> > > release...
> > >
> > > Vincent, could you try to just get rid of all actual uses of
> > > se->attr.owner, within fs/sysfs/*.c? Something like the patch below.
> > > (totally untested - might be fatally broken as well)
> >
> > How can you think that this is not needed? You can not remove it with
> > sysfs you are patching. Hope this explains it:
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0ab66088c855eca68513bdd7442a426c4b374ced
>
> yeah - as i said it might be fatally broken (in fact it is). Do we
> understand why Vincent got the crashes with vanilla 2.6.22.14 ?
>

My guess is some variables have probably been left uninitialized. I am a
bit too scared to look into sysfs parts of the code now.

--
regards,
Dhaval
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/