Re: [PATCH 2/6] SUNRPC: Break up __svc_create_thread and makesvc_create_kthread

From: Christoph Hellwig
Date: Thu Dec 13 2007 - 16:07:12 EST


On Thu, Dec 13, 2007 at 03:40:24PM -0500, Jeff Layton wrote:
> Move the initialization that happens prior to thread creation to a new
> function (svc_prepare_thread) so that we can call it from a new thread
> creation routine. Add a new function svc_create_kthread that spawns svc
> threads using kthread API.
>
> We should be able to eventually convert all of the callers to the
> kthread API, at which point we can drop __svc_create_thread.

> +static struct svc_rqst *
> +svc_prepare_thread(svc_thread_fn func, struct svc_serv *serv,
> + struct svc_pool *pool)

Could you just export this helper? I'd rather have callers have full
control over how they create their threads and call into a helper to
initialize the sunrpc state.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/