Re: 2.6.22.14 oops msg with commvault galaxy ?

From: Kay Sievers
Date: Thu Dec 13 2007 - 11:25:08 EST



On Thu, 2007-12-13 at 15:02 +0000, Vincent Fortier wrote:
> On Thu, 2007-12-13 at 08:59 -0500, Kay Sievers wrote:
> > On Thu, 2007-12-13 at 13:55 +0100, Ingo Molnar wrote:
> > > * Dhaval Giani <dhaval@xxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > > Could you please see if the following patch removes the oops due
> > to
> > > > CFS sysfs files? (There might still be the other oops due to the
> > > > floppy sysfs files)
> > > >
> > > > Ingo, could you please add this patch in your CFS backport to
> > 2.6.22
> > > > and older kernels?
> > >
> > > sure - i've updated the backport patches with this fix.
> > >
> > > > static void user_attr_init(struct subsys_attribute *sa, char
> > *name, int mode)
> > > > {
> > > > + sa->attr.owner = NULL;
> > > > sa->attr.name = name;
> > >
> > > i'm wondering why doesnt this affect 2.6.23 and later? Does sysfs
> > > initialize the owner field to NULL automatically?
> >
> > Attibutes do not have an owner anymore:
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7b595756ec1f49e0049a9e01a1298d53a7faaa15
>
> This one also fails to apply properly at the exact same place has Ingo's
> previously posted patch. Would need to backport his one.

It depends on a completely reworked sysfs logic, I don't think it makes
any sense to backport that.

Kay

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/