Re: [PATCH] NLM: Add lockd reference counting and clean up lockdstartup and shutdown

[Jeff Layton]

On Sat, 8 Dec 2007 14:07:47 +0000
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> > +	mutex_lock(&nlmsvc_mutex);
> > +	while (atomic_read(&nlmsvc_ref) != 0) {
> 
> might be better to do the refcounting outside the thread and use the
> kthread api, which is something we still need to do for lockd anyway.
> 

I took a swipe at doing this, and have a set of patches that make lockd
use kthreads. It works well, but there's a problem once I add in the
reference counting.

In the situation that prompted this whole thing, the last nlmsvc_ref
gets put by lockd itself. A kthread can't call kthread_stop on itself
since it will deadlock.

Is there a way to gracefully allow a kthread to shut itself down?
Alternately, I suppose I could schedule_work() the kthread_stop, though
that seems sort of ugly...

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/