Re: [PATCH] Revert lazy irq disable for simple irqs

[Steven Rostedt]

On Thu, 13 Dec 2007, Ingo Molnar wrote:

>
> * Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> > [This patch *is* for mainline Linux]
> >
> > In commit 76d2160147f43f982dfe881404cfde9fd0a9da21 lazy irq disabling
> > was implemented, and the simple irq handler had a masking set to it.

>
> thanks, applied. This is for v2.6.24 too, right?
>

Probably should be. The patch only reverts the change for
handle_simple_irq that shouldn't have been done in the first place. At
worse, this patch just takes us back to what handle_simple_irq use to do,
and at best, it prevents bugs where we somehow fall into the "mask" path
of handle_simple_irq and never unmask. But to hit that path, the driver
probably shouldn't be using handle_simple_irq ;-)

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/