Re: [PATCH 19/19] unify set_tss_desc

[Andi Kleen]

> +static inline void pack_tss(tss_desc *tss, unsigned long addr,
> +			   unsigned size, unsigned entry)
> +{
> +#ifdef CONFIG_X86_64
> +		set_tssldt_descriptor(tss,
> +			     addr, entry, size);
> +#else
> +		pack_descriptor(tss, (unsigned long)addr,
> +				size,
> +				0x80 | entry, 0);

It would be better if you just unified that first instead of ifdef'ing.
I guess i386 could get a set_tssldt_descriptor() like wrapper
around pack_descriptor(). 

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/