Re: Possible issue with dangling PCI BARs

From: Benjamin Herrenschmidt
Date: Thu Dec 13 2007 - 06:20:50 EST



> > Supporting pci_enable_device_io / pci_enable_device_mmio / pci_iomap_io /
> > pci_iomap_mmio seems to cover pretty much all the use cases we have.
> >
> > The users we have right now that are:
> >
> > - pata_cs5520 (can be dealt with easily)
> > - old IDE (with the new resource handling for legacy IDE
> > can use pci_enable_device_io I think, ditto pci/cs5520)
> > - scx200_acb (looks like a simple substitution works)
> > - lpfc pci_enable_device_mmio
> > - qla2xxx pci_enable_device ? (enables IO and MMIO)

I may have not fully undestood you in my previous reply. You are proposing
replacing pci_enable_device_bars() with a pair of pci_enable_device_io/mem ?

I think that would be a good idea indeed.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/