Re: [PATCH] x86: Remove 'e' from kprope structure members

[Jeremy Fitzhardinge]

H. Peter Anvin wrote:
> Jeremy Fitzhardinge wrote:
>> Harvey Harrison wrote:
>>> Some kprobe structure members had a superfluous e in their
>>> name.
>>>
>>> eflags -> flags
>>> esp -> sp
>>>   
>>
>> eflags and esp are the actual machine register names (at least in
>> 32-bit), and therefore more distinctive than just "flags".
>> If this is in preparation for a unification then OK, but I disagree if
>> not (and technically 64-bit should be using rsp/rflags).
>>
>
> Yes, that's the whole point (unification.) 

OK, great.  I was just confused because the patch changelog didn't give
a proper rationale for the change (the 'e' isn't superfluous, and
removing it isn't a goal in itself).

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/