Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)

From: Robert Hancock
Date: Sat Dec 08 2007 - 13:38:27 EST


Jeff Garzik wrote:
Robert Hancock wrote:
This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode
on systems with memory located above 4GB. We need to delay setting the 64-bit
DMA mask until the PRD table and padding buffer are allocated so that they don't
get allocated above 4GB and break legacy mode (which is needed for ATAPI
devices).

Signed-off-by: Robert Hancock <hancockr@xxxxxxx>

This is a bit nasty :/

I would consider setting the consistent DMA mask to 32-bit, and setting the overall mask to 64-bit.

Seems like that would solve the problem?

Also, does this need to be rebased on top of what I just pushed upstream?

Jeff

Jeff, ping on this one? This (or, one like it) really should make it into 2.6.24..

--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@xxxxxxxxxxxxx
Home Page: http://www.roberthancock.com/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/