Re: [patch 0/2] x86, ptrace: support for branch trace store(BTS)

From: Ingo Molnar
Date: Fri Nov 30 2007 - 05:55:34 EST



* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> The patches were horridly wordwrapped.

yep, i already tried to check how well it integrates to x86.git:

http://lkml.org/lkml/2007/11/29/93

the code does not seem to be layered correctly: i'd suggest to read the
discussion between Roland McGrath and Alan Stern on lkml, about kwatch
-> hw_breakpoint, to see how a more general debugging framework
can/should be built. These things shouldnt be limited to user-space
alone, the kernel could probably use hardware tracing even more than
user-space could. (because it's a much harder to debug environment)

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/