Re: [PATCH PREEMPT_RT]: On AT91 ARM: GPIO Interrupt handling can/willstall forever

From: Steven Rostedt
Date: Thu Nov 29 2007 - 11:36:48 EST



On Thu, 29 Nov 2007, Remy Bohmer wrote:

> I changed the interrupt handler from the simple_irq to the edge_irq,
> and it works...!!
> (I added a noop routine for that .ack part, because there is no ack)
>
> I believe I was too focussed on the masking bug in the RT kernel on
> the simple_irq() that I did not see that for the AT91 series the edge
> type interrupt handler also works... (even better...) What I thought
> was 1 single bug in the RT-kernel turned out to be a number of things
> together that aren't correct, even for mainline.
>
> So, to come to a conclusion: The masking bug in RT is still there in
> the simple_irq path, and masking has to be removed from the simple_irq
> code. Also for mainline. AT91 can live without simple_irq.
> I think we are in sync again...
>
> I will post a patch for the AT91 later on, after some more testing.


Remy,

Thanks a lot for figuring this out!! Makes me feel better for the NACK ;-)

If you also want to send me a patch to remove the masking in the
simple_irq code, please do.

Thanks,

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/