Re: [patch 1/2] x86, ptrace: support for branch trace store(BTS)

From: Ingo Molnar
Date: Thu Nov 29 2007 - 05:43:56 EST



* Metzger, Markus T <markus.t.metzger@xxxxxxxxx> wrote:

> Changes to previous version(s):
> - moved task arrives/departs notifications to __switch_to_xtra()
> - added _TIF_BTS_TRACE and _TIF_BTS_TRACE_TS to _TIF_WORK_CTXSW_*
> - split _TIF_WORK_CTXSW into ~_PREV and ~_NEXT for x86_64
> - ptrace_bts_init_intel() function called from init_intel()
> - removed PTRACE_BTS_INIT ptrace command
> - cache DEBUGCTRL MSR
> - replace struct declarations and operations struct with
> configuration struct defining offset/size pairs and
> generic operations
> - added a patch for the ptrace.2 man page for discussing the API
> in this forum

i tried to apply your patches to x86.git, but your patches were
linewrapped and had strange artifacts in them:

| @@ -610,6 +612,32 @@
| (struct user_desc __user *)
| data);
| break;
| =20
| + case PTRACE_BTS_ALLOCATE_BUFFER:
| +

could you please resend with this fixed (preferably against x86.git,
which has Roland's ptrace cleanups?).

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/