Re: [PATCH][for -mm] per-zone and reclaim enhancements for memorycontroller take 3 [3/10] per-zone active inactive counter

From: KAMEZAWA Hiroyuki
Date: Wed Nov 28 2007 - 22:23:35 EST


On Thu, 29 Nov 2007 12:19:37 +0900 (JST)
yamamoto@xxxxxxxxxxxxx (YAMAMOTO Takashi) wrote:

> > @@ -651,10 +758,11 @@
> > /* Avoid race with charge */
> > atomic_set(&pc->ref_cnt, 0);
> > if (clear_page_cgroup(page, pc) == pc) {
> > + int active;
> > css_put(&mem->css);
> > + active = pc->flags & PAGE_CGROUP_FLAG_ACTIVE;
> > res_counter_uncharge(&mem->res, PAGE_SIZE);
> > - list_del_init(&pc->lru);
> > - mem_cgroup_charge_statistics(mem, pc->flags, false);
> > + __mem_cgroup_remove_list(pc);
> > kfree(pc);
> > } else /* being uncharged ? ...do relax */
> > break;
>
> 'active' seems unused.
>
ok, I will post clean-up against -mm2.

Thanks,
-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/