Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.hinstead

[Richard Knutsson]

Denis Cheng wrote:
> Cc: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Signed-off-by: Denis Cheng <crquan@xxxxxxxxx>
> ---
> this is against the lastest cryptodev tree.
>
>  crypto/tcrypt.c |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
> index 1e12b86..ae762c2 100644
> --- a/crypto/tcrypt.c
> +++ b/crypto/tcrypt.c
> @@ -87,12 +87,11 @@ static char *check[] = {
>  	"camellia", "seed", "salsa20", NULL
>  };
>  
> -static void hexdump(unsigned char *buf, unsigned int len)
> +static inline void hexdump(unsigned char *buf, unsigned int len)
>  {
> -	while (len--)
> -		printk("%02x", *buf++);
> -
> -	printk("\n");
> +	print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET,
> +			16, 1,
> +			buf, len, 0);
>   
Not important, but why use '0' instead of 'false'?
>  }
>  
>  static void tcrypt_complete(struct crypto_async_request *req, int err)
>   
cu
Richard Knutsson

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/