Re: [2.6 patch] ipv4/arp.c:arp_process(): remove bogus #ifdef mess

From: Herbert Xu
Date: Mon Nov 26 2007 - 10:20:34 EST


On Sun, Nov 25, 2007 at 04:30:03PM +0000, Adrian Bunk wrote:
> > >
> > > Please look at net/ipv4/arp.c:arp_process()
> > >
> > > Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or
> > > CONFIG_NETDEV_10000=y will not be handled correctly there?
> > >
> > > And the best solution is to nuke all #ifdef's in this function and make
> > > the code unconditionally available?
> >
> > I think removing those specific ifdefs in arp_process()
> > is the best option, yes.
>
> Patch below.

Thanks Adrian. Patch applied to net-2.6.

Do we need this for stable too?

Chers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/