Re: [PATCH] scatterlist: add more safeguards

From: Jens Axboe
Date: Mon Nov 26 2007 - 09:44:30 EST


On Mon, Nov 26 2007, Tejun Heo wrote:
> Add more safeguards to protect against misinterpreting a chain entry
> as a normal scatterlist and vice-versa.
>
> * Make sure the entry isn't a chain when assigning and reading a
> normal sg.
>
> * Clear offset and length when chaining.
>
> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
> ---
> While converting libata to use chained-sg, I felt a bit insecure and
> added a few more safe guards. Feel free to include or ignore them.

Looks sane, thanks Tejun! Will apply it.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/