Re: [PATCH] sata_nv: don't use legacy DMA in ADMA mode (v3)

From: Tejun Heo
Date: Sun Nov 25 2007 - 21:20:42 EST


Robert Hancock wrote:
> We need to run any DMA command with result taskfile requested in ADMA mode
> when the port is in ADMA mode, otherwise it may try to use the legacy DMA engine
> in ADMA mode which is not allowed. Enforce this with BUG_ON() since data
> corruption could potentially result if this happened. Also, fail any attempt to
> try and issue NCQ commands with result taskfile requested, since the hardware
> doesn't allow this.
>
> Signed-off-by: Robert Hancock <hancockr@xxxxxxx>

Acked-by: Tejun Heo <htejun@xxxxxxxxx>

Thanks.

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/