Re: [PATCH 5/5] x86: TLS cleanup

From: Zachary Amsden
Date: Wed Nov 21 2007 - 13:31:24 EST


On Wed, 2007-11-21 at 02:25 -0800, Roland McGrath wrote:
> This consolidates the four different places that implemented the same
> encoding magic for the GDT-slot 32-bit TLS support. The old tls32.c is
> renamed and only slightly modified to be the shared implementation guts.

> -#define GET_BASE(desc) ( \
> - (((desc)->a >> 16) & 0x0000ffff) | \
> - (((desc)->b << 16) & 0x00ff0000) | \
> - ( (desc)->b & 0xff000000) )
> -
> -#define GET_LIMIT(desc) ( \
> - ((desc)->a & 0x0ffff) | \
> - ((desc)->b & 0xf0000) )

That was the other redundant definition, thanks.

I had a bit of trouble verifying correctness here because of much
brownian motion. Any possibility of a pure movement / fixup separation
to make it easier on the eyes?

Zach

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/